fabian/pitrix
1
0
Fork 0
Code Issues 8 Releases Activity

Fixed memory leak in random_matrix and rainbow_matrix.

Browse Source
This commit is contained in:
Fabian Schlenz 2019-10-04 12:08:01 +02:00
parent af1314632e
commit 2b50691067
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/effect_matrix.cpp
View File

@ -144,13 +144,19 @@ MatrixEffect::MatrixEffect() {
} }
RandomMatrixEffect::RandomMatrixEffect() { RandomMatrixEffect::RandomMatrixEffect() {
_columns = new MatrixEffectColumn* [window->width]; // No need to initialize _columns, because that will have been done by ctor of MatrixEffect.
for (int i=0; i<window->width; i++) _columns[i] = new RandomMatrixEffectColumn(window, random8(4), true); for (int i=0; i<window->width; i++) {
delete _columns[i];
_columns[i] = new RandomMatrixEffectColumn(window, random8(4), true);
}
} }
RainbowMatrixEffect::RainbowMatrixEffect() { RainbowMatrixEffect::RainbowMatrixEffect() {
_columns = new MatrixEffectColumn* [window->width]; // No need to initialize _columns, because that will have been done by ctor of MatrixEffect.
for (int i=0; i<window->width; i++) _columns[i] = new RainbowMatrixEffectColumn(window, MatrixEffectColumn::DIR_SOUTH); for (int i=0; i<window->width; i++) {
delete columns[i];
_columns[i] = new RainbowMatrixEffectColumn(window, MatrixEffectColumn::DIR_SOUTH);
}
} }
MatrixEffect::~MatrixEffect() { MatrixEffect::~MatrixEffect() {