fabian/esmp3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Player: Prevent overflows in vol_up() and vol_down().

Browse Source
This commit is contained in:
Fabian Schlenz 2019-11-29 21:24:41 +01:00
parent 547080acf5
commit 0dd5937707
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/player.cpp
View File

@ -464,14 +464,14 @@ void Player::set_volume(uint8_t vol, bool save) {
void Player::vol_up() { void Player::vol_up() {
if (!is_playing()) return; if (!is_playing()) return;
uint8_t vol = _volume + VOLUME_STEP; uint16_t vol = _volume + VOLUME_STEP;
if (vol > VOLUME_MAX) vol=VOLUME_MAX; if (vol > VOLUME_MAX) vol=VOLUME_MAX;
set_volume(vol); set_volume(vol);
} }
void Player::vol_down() { void Player::vol_down() {
if (!is_playing()) return; if (!is_playing()) return;
uint8_t vol = _volume - VOLUME_STEP; int16_t vol = _volume - VOLUME_STEP;
if (vol < VOLUME_MIN) vol=VOLUME_MIN; if (vol < VOLUME_MIN) vol=VOLUME_MIN;
set_volume(vol); set_volume(vol);
} }